ci: bump/pin to ubuntu-20.04 #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
November 23, 2022 15:40
ljbade
reviewed
Nov 23, 2022
.github/workflows/c.yaml
Outdated
| bash <(curl -s https://codecov.io/bash) -s c/build || echo "Codecov did not collect coverage reports"; | ||
| # - name: Upload coverage to codecov.io | ||
| # run: | | ||
| # bash <(curl -s https://codecov.io/bash) -s c/build || echo "Codecov did not collect coverage reports"; |
There was a problem hiding this comment.
We aren't using codecov.io anymore (we closed our account) -- so this should be migrate to SonarCloud eventually
silverjam
commented
Nov 23, 2022
| @@ -12,34 +12,9 @@ on: | |||
| - "c/**" | |||
| - .github/workflows/c.yaml | |||
| jobs: | |||
| coverage: | |||
| name: Code Coverage | |||
There was a problem hiding this comment.
Removed this stage since it isn't doing anything, we've deleted our code cov account
ljbade
approved these changes
Nov 23, 2022
|
I suppose we could add Sonarcloud if we want coverage report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI: bump and pin to Ubuntu 20.04 to fix recent CI breakage
API compatibility
n/a
JIRA Reference
n/a